Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stat Generation update #3

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Stat Generation update #3

merged 2 commits into from
Jan 19, 2021

Conversation

JLDesignNetwork
Copy link
Contributor

  • Minor modifications made on how data is output to the editor. (selections and ranges are used, to remove the original call in the editor; used for stat generation)
  • Added 2 methods of stat generations.
  • Added a second regular expression; used for stat matching.
  • Modified the original regular expression; caused a small bug with the added functionality.
  • Changed the format of the output for dice rolling. The original dice roll call is kept, and only the results are appended; not the results and roll call. Uses string formatting and dividers to maintain a clean look.
  • Maintains the ability to continuously press ctrl-r for as many rolls are needed.

 - stat generation (2 methods)
 - new configuration settings
 - developer log messages
 - output formatting
Changed:
 - output display
@JLDesignNetwork
Copy link
Contributor Author

Sample output of the changes I have made. The stat generation methods used are those that were typical when I used to play dungeons and dragons. Also, you may notice that the images for critical success and failures are applied to all dice rolls. I included this because, again when I played, it was common to count critical success and failure for damage rolls.

(+3) |  21 |  15 | 💣 4 |   7 |  15 |  12 |  13 |  21 | 💣 4 |  14 |  21 |   6
(1d4) |   2 |   2 | 🌟 4 | 🌟 4 |   2 |   3 |   2 |   3 |   2 | 🌟 4 | 💣 1
(1d4+2) | 🌟 6 | 🌟 6 | 🌟 6 |   4 | 💣 3 |   5 | 🌟 6 |   4 | 🌟 6 |   5
(1d12+12) |  20 |  16 |  18 |  20 |  21 |  14 |  14 |  22 |  21 |  23 |  23 |  19
(10d6+15) |  48 |  45 |  47 |  49 |  49 |  51 |  53 |  51 |  47 |  56 |  52 |  57
(1d20+4) |   9 |  16 |  21 |  18 |  21 |  19 |  20 |   7 |   8 |  21 |   6 |  19

*=======================================*
* STAT GENERATION: (stat)
*=======================================* 
* METHOD: default = 3 (3d6)
* This method rolls 3 sets of 3d6 per
* stat and keeps the best set.
*=======================================* 
* NOTES: ran 10 times.
*=======================================*
Ability Score Pool:  14 (+2) | 13 (+1) | 10 (+0) | 16 (+3) | 15 (+2) | 12 (+1)
Ability Score Pool:  13 (+1) | 15 (+2) | 12 (+1) | 13 (+1) | 12 (+1) | 12 (+1)
Ability Score Pool:  12 (+1) | 11 (+0) | 11 (+0) | 11 (+0) | 14 (+2) | 14 (+2)
Ability Score Pool:  14 (+2) | 13 (+1) | 14 (+2) | 15 (+2) | 18 (+4) | 15 (+2)
Ability Score Pool:  13 (+1) | 13 (+1) |  9 (-1) | 14 (+2) | 12 (+1) | 16 (+3)
Ability Score Pool:  14 (+2) | 15 (+2) | 12 (+1) | 13 (+1) | 16 (+3) | 12 (+1)
Ability Score Pool:  12 (+1) | 12 (+1) | 11 (+0) |  8 (-1) | 14 (+2) | 14 (+2)
Ability Score Pool:  14 (+2) | 13 (+1) | 14 (+2) | 13 (+1) | 12 (+1) | 11 (+0)
Ability Score Pool:  10 (+0) | 16 (+3) | 15 (+2) | 11 (+0) | 10 (+0) | 11 (+0)
Ability Score Pool:  14 (+2) | 13 (+1) | 16 (+3) | 13 (+1) | 15 (+2) | 14 (+2)

*=======================================*
* STAT GENERATION: (stat:3-5)
*=======================================* 
* METHOD: default = 3 (3d6);
* This method rolls 3 sets of 3d6 per
* stat and keeps the best set.
*=======================================* 
* COUNT: default = 3;
* We are using a non-default count of 5.
* Instead of rolling 3 sets of 3d6 per
* stat, we are rolling 5 sets.
*=======================================* 
* NOTES: ran 10 times.
*=======================================*
Ability Score Pool:  16 (+3) | 15 (+2) | 14 (+2) | 14 (+2) | 13 (+1) | 13 (+1)
Ability Score Pool:  17 (+3) | 16 (+3) | 14 (+2) | 13 (+1) | 12 (+1) | 12 (+1)
Ability Score Pool:  14 (+2) | 13 (+1) | 14 (+2) | 14 (+2) | 15 (+2) | 15 (+2)
Ability Score Pool:  12 (+1) | 11 (+0) | 18 (+4) | 17 (+3) | 15 (+2) | 14 (+2)
Ability Score Pool:  12 (+1) | 14 (+2) | 14 (+2) | 15 (+2) | 14 (+2) | 14 (+2)
Ability Score Pool:  11 (+0) | 16 (+3) | 14 (+2) | 10 (+0) | 12 (+1) | 12 (+1)
Ability Score Pool:  16 (+3) | 12 (+1) | 15 (+2) | 14 (+2) | 12 (+1) | 13 (+1)
Ability Score Pool:  14 (+2) | 14 (+2) | 16 (+3) | 13 (+1) | 13 (+1) |  9 (-1)
Ability Score Pool:  15 (+2) | 16 (+3) | 12 (+1) | 13 (+1) | 17 (+3) | 15 (+2)
Ability Score Pool:  17 (+3) | 12 (+1) | 17 (+3) | 13 (+1) | 14 (+2) | 14 (+2)

*=======================================*
* STAT GENERATION: (stat:4)
*=======================================* 
* METHOD: 4 (4d6)
* This method rolls 4 sets of 1d6 per
* stat. The best 3 rolls of each set is
* totaled.
*=======================================* 
* NOTES: ran 10 times.
*=======================================* 
* ADDITIONAL: This method does not 
* accept a count argument.
*=======================================*
Ability Score Pool:  13 (+1) | 14 (+2) | 10 (+0) |  9 (-1) | 14 (+2) | 15 (+2)
Ability Score Pool:  14 (+2) |  9 (-1) | 11 (+0) |  9 (-1) | 14 (+2) | 15 (+2)
Ability Score Pool:  13 (+1) | 14 (+2) | 12 (+1) | 12 (+1) |  8 (-1) | 11 (+0)
Ability Score Pool:  14 (+2) | 12 (+1) |  9 (-1) | 11 (+0) | 14 (+2) |  8 (-1)
Ability Score Pool:  16 (+3) | 18 (+4) | 13 (+1) |  6 (-2) | 18 (+4) |  9 (-1)
Ability Score Pool:  12 (+1) | 10 (+0) |  7 (-2) | 14 (+2) |  8 (-1) | 14 (+2)
Ability Score Pool:  13 (+1) | 11 (+0) | 10 (+0) | 14 (+2) | 18 (+4) | 10 (+0)
Ability Score Pool:  13 (+1) | 16 (+3) | 11 (+0) | 10 (+0) | 12 (+1) | 11 (+0)
Ability Score Pool:  16 (+3) | 18 (+4) | 12 (+1) | 13 (+1) | 14 (+2) |  7 (-2)
Ability Score Pool:  15 (+2) | 11 (+0) | 11 (+0) | 11 (+0) | 12 (+1) | 10 (+0)

@JLDesignNetwork
Copy link
Contributor Author

dice-rolls_J8Uw4juq.mov

@JLDesignNetwork
Copy link
Contributor Author

stats_WjdEdFPJ.mov

@akstuhl
Copy link
Owner

akstuhl commented Jan 19, 2021

This is fantastic! The stat generation is a great idea and very nicely implemented with the modifiers + configuration options; so are the other improvements. I'll merge this now and then push an update to the package soon with appropriate changes to the readme and changelog noting your contribution.

@akstuhl akstuhl merged commit fd8440a into akstuhl:main Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants