Skip to content

Commit

Permalink
chore: address cr comments
Browse files Browse the repository at this point in the history
Service account annotations are completely separated from other
annotations, for now at least.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
  • Loading branch information
blakepettersson committed Jul 6, 2024
1 parent 04e0dcf commit 42cfda9
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
6 changes: 2 additions & 4 deletions charts/kargo/templates/controller/service-account.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,8 @@ metadata:
labels:
{{- include "kargo.labels" . | nindent 4 }}
{{- include "kargo.controller.labels" . | nindent 4 }}
{{- with (mergeOverwrite (deepCopy .Values.global.annotations) .Values.controller.annotations) }}
{{- with .Values.controller.serviceAccount.annotations }}
annotations:
{{- range $key, $value := . }}
{{ $key }}: {{ $value | quote }}
{{- end }}
{{- toYaml . | nindent 4 }}
{{- end }}
{{- end }}
5 changes: 5 additions & 0 deletions charts/kargo/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,11 @@ controller:
## @param controller.podAnnotations Optional annotations to add to pods. Merges with `global.podAnnotations`, allowing you to override or add to the global annotations.
podAnnotations: {}

## All settings relating to the service account for the controller
serviceAccount:
## @param controller.serviceAccount.annotations Optional annotations to add to the service account.
annotations: {}

## All settings relating to shared credentials (used across multiple kargo projects)
globalCredentials:
## @param controller.globalCredentials.namespaces List of namespaces to look for shared credentials.
Expand Down

0 comments on commit 42cfda9

Please sign in to comment.