Skip to content

Commit

Permalink
Update internal/directives/simple_engine_promote.go
Browse files Browse the repository at this point in the history
  • Loading branch information
krancour authored Dec 5, 2024
1 parent 8db25c0 commit 99a990a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/directives/simple_engine_promote.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func (e *SimpleEngine) executeSteps(
}

// Treat errors and logical failures the same for now.
// TODO(krancour): These may be handled differently in the future.
// TODO(krancour): In the future, we should fail without retry for logical failures and unrecoverable errors and retry only those errors with a chance of recovery.

Check failure on line 134 in internal/directives/simple_engine_promote.go

View workflow job for this annotation

GitHub Actions / lint-go

the line is 167 characters long, which exceeds the maximum of 120 characters. (lll)
if stepExecMeta.Status != kargoapi.PromotionPhaseRunning {
stepExecMeta.ErrorCount++
// Check if the error threshold has been met.
Expand Down

0 comments on commit 99a990a

Please sign in to comment.