Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warehouse refresh from UI should update freightline #1202

Closed
jessesuen opened this issue Dec 1, 2023 · 1 comment · Fixed by #1244 or #1276
Closed

Warehouse refresh from UI should update freightline #1202

jessesuen opened this issue Dec 1, 2023 · 1 comment · Fixed by #1244 or #1276

Comments

@jessesuen
Copy link
Member

Proposed Feature

When clicking refresh on a Warehouse, the freightline should be updated automatically once the refresh annotation is cleared.

NOTE: we used to do this when refreshing the stage, but now that Warehouses are responsible for producing freight (and not stages), we need the UI to adjust accordingly.

Motivation

Currently I have to do a browser refresh to see new freight.

Suggested Implementation

@jessesuen
Copy link
Member Author

jessesuen commented Dec 7, 2023

@rbreeze - warehouse refresh is async. e.g. we click the button that sets an annotation, but that annotation may not be cleared for another minute (whenever the reconciler gets to it), at which point there will be new Freight.

The fix seems too simple to handle it properly. e.g. I think it only refetches freight immediately after the API returns / mouse click, but the freight may not have been produced yet until a minute later.

I expected the implementation to be similar to refresh stage, where we show a progressing icon so long as the annotation is present, and only when the annotation is cleared do we refetch freight in UI and clear the spinner.

Reopening, but feel free to close if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants