fix: refresh freightline after warehouse completes refresh #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Remington Breeze <remington@breeze.software>
❌ Deploy Preview for docs-kargo-akuity-io failed.
|
rbreeze
commented
Dec 14, 2023
| @@ -37,7 +37,10 @@ export const RepoNode = ({ nodeData, children }: Props) => { | |||
| <div className='text-ellipsis whitespace-nowrap overflow-hidden'> | |||
| {nodeData.warehouseName} | |||
| </div> | |||
| {nodeData.type !== NodeType.REPO_CHART && <FontAwesomeIcon icon={faBuilding} />} | |||
| <div className='flex items-center'> | |||
| {nodeData.refreshing && <FontAwesomeIcon icon={faCircleNotch} spin className='mr-2' />} | |||
There was a problem hiding this comment.
Adds refresh indicator for Warehouse nodes
Signed-off-by: Remington Breeze <remington@breeze.software>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1276 +/- ##
==========================================
+ Coverage 48.50% 48.79% +0.29%
==========================================
Files 127 127
Lines 9675 9746 +71
==========================================
+ Hits 4693 4756 +63
- Misses 4823 4830 +7
- Partials 159 160 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
rbreeze
commented
Dec 14, 2023
| refetchAvailableFreight(); | ||
| } | ||
|
|
||
| const refreshing = e.warehouse?.metadata?.annotations['kargo.akuity.io/refresh']; |
There was a problem hiding this comment.
If refresh annotation is found on a warehouse, we don't refetch freight yet. Instead, save it to a map which indicates it started refreshing
| refresh[e.warehouse?.metadata?.name || ''] = true; | ||
| alert('detected refresh for warehouse'); | ||
| } else if (refresh[e.warehouse?.metadata?.name || '']) { | ||
| delete refresh[e.warehouse?.metadata?.name || '']; |
There was a problem hiding this comment.
If refresh annotation is not present, and this warehouse was refreshing previously, remove it from the map and refresh the freight line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1202 (for real this time 🙂)