Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kargo CLI should have a --client option #1511

Closed
4 tasks done
christianh814 opened this issue Feb 22, 2024 · 1 comment · Fixed by #1516
Closed
4 tasks done

Kargo CLI should have a --client option #1511

christianh814 opened this issue Feb 22, 2024 · 1 comment · Fixed by #1516

Comments

@christianh814
Copy link
Member

christianh814 commented Feb 22, 2024

Checklist

  • I've searched the issue queue to verify this is not a duplicate bug report.
  • I've included steps to reproduce the bug.
  • I've pasted the output of kargo version.
  • I've pasted logs, if applicable.

Description

The Kargo CLI command kargo version doesn't return the version of the CLI if there is no connection to the server. This comes up for me when there is a "stale" connection still cached.

Example

$ kargo version
Error: get client from config: error refreshing token: your token is expired; please use `kargo login` to re-authenticate
$ rm -rf ~/.config/kargo
$ kargo version
Client Version: v0.4.0

Steps to Reproduce

  1. Have a "stale" login creds under ~/.config/kargo
  2. Download Kargo CLI v0.4.0
  3. Run kargo version

Version

Client Version: v0.4.0

Enhancement Proposal

There should be a --client option that just displays the version of the cli, bypassing the server version check.

Example

$ kargo version
Error: get client from config: error refreshing token: your token is expired; please use `kargo login` to re-authenticate
$ kargo version --client
Client Version: v0.4.0
@krancour
Copy link
Member

Agree. And besides that, when --client isn't specified, we should print CLI version info before handling any connection errors so that you at least see part of what you were looking for.

@hiddeco would you be willing to take this as another "warm up?" If so, know that there's an open issue for a more comprehensive CLI overhaul, so don't worry about making this perfect. Just make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants