feat(cli): add --client flag to kargo version
#1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for supplying a `--client` flag to `kargo version`,
which avoids the command from attempting to collect version information
from the API server.
```console
$ kargo version --client
Client Version: devel+unknown.dirty
```
In addition, the order of collecting information has been adjusted to
allow partial information to be printed when the API server can not
be reached before returning an error.
```console
$ kargo version
Client Version: devel+unknown.dirty
Error: get version info from server: unavailable: dial tcp [::1]:30081: connect: connection refused
$ kargo version --output yaml
apiVersion: kargo.akuity.io/v1alpha1
cli:
buildTime: "2024-02-22T11:18:51Z"
compiler: gc
gitTreeDirty: true
goVersion: go1.21.3
platform: linux/amd64
version: devel+unknown.dirty
kind: ComponentVersions
Error: get version info from server: unavailable: dial tcp [::1]:30081: connect: connection refused
```
However, in case `--output` is provided and the printer itself runs
into an issue, this error takes precedence.
```console
$ kargo version --output go-template --template '{{ .cli.version }'
Error: new printer: error parsing template {{ .cli.version }, template: output:1: unexpected "}" in operand
```
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
krancour
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1511
This adds support for supplying a
--clientflag tokargo version, which avoids the command from attempting to collect version information from the API server.In addition, the order of collecting information has been adjusted to allow partial information to be printed when the API server can not be reached before returning an error.
However, in case
--outputis provided and the printer itself runs into an issue, this error takes precedence.