Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: edit modals should use YAML option from API get endpoints #1960

Closed
hiddeco opened this issue May 6, 2024 · 1 comment
Closed

ui: edit modals should use YAML option from API get endpoints #1960

hiddeco opened this issue May 6, 2024 · 1 comment

Comments

@hiddeco
Copy link
Contributor

hiddeco commented May 6, 2024

Edit modals like the one for Stages should use the YAML option from the respective get endpoint. Without it, the update they will issue will lack GVK information about the object. Which causes the operation to fail with an error like:

parse manifest: error unmarshaling manifest: error unmarshaling JSON: while decoding JSON: Object 'Kind' is missing in ''

An example of where this is being done correctly is

const { data, isLoading } = useQuery(getAnalysisRun, {
namespace: projectName,
name,
format: RawFormat.YAML
});

@hiddeco
Copy link
Contributor Author

hiddeco commented May 6, 2024

Already addressed by #1898.

@hiddeco hiddeco closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant