feat(ui): Edit AnalysisTemplate #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1898 +/- ##
==========================================
- Coverage 46.73% 45.52% -1.22%
==========================================
Files 220 235 +15
Lines 14415 15823 +1408
==========================================
+ Hits 6737 7203 +466
- Misses 7378 8267 +889
- Partials 300 353 +53 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
rbreeze
approved these changes
Apr 30, 2024
| format: RawFormat.YAML | ||
| }); | ||
|
|
||
| const manifest = new TextDecoder().decode( |
There was a problem hiding this comment.
This is the second time this logic is used - maybe worth creating a utility function.
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1785
In this PR I also introduced an option to hide Managed Fields inside the Yaml Editor.