Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom PR Title #3063

Closed
2 of 3 tasks
mmclane opened this issue Dec 5, 2024 · 0 comments · Fixed by #3107
Closed
2 of 3 tasks

Custom PR Title #3063

mmclane opened this issue Dec 5, 2024 · 0 comments · Fixed by #3107
Assignees
@krancour @mmclane
Labels
area/controller help-wanted Community help on this would be appreciated kind/enhancement priority/normal size/medium
Milestone
v1.2.0

Comments

@mmclane
Copy link

mmclane commented Dec 5, 2024

Checklist

  • I've searched the issue queue to verify this is not a duplicate feature request.
  • I've pasted the output of kargo version, if applicable.
  • I've pasted logs, if applicable.

Proposed Feature

It would be really great if we could set a custom PR title via the git-open-pr step. Either completely override the last commit massage or, if possible, Add to the title.

Motivation

As suggested #3002
I can absolutely forsee someone wanting the ability to customize the title and thus overriding the last commit message

I know a lot of shops will add things like [staging] or [release] at the beginning of the title which might trigger automated workflows as an example.

Suggested Implementation
muenchdo added a commit to muenchdo/kargo that referenced this issue Dec 9, 2024
@muenchdo
feat: custom PR title (akuity#3063)
6ece8b4
muenchdo added a commit to muenchdo/kargo that referenced this issue Dec 9, 2024
@muenchdo
feat: custom PR title (akuity#3063)
c93d1eb
@krancour krancour added area/controller help-wanted Community help on this would be appreciated and removed kind/proposal labels Dec 9, 2024
muenchdo added a commit to muenchdo/kargo that referenced this issue Dec 9, 2024
@muenchdo
feat: custom PR title (akuity#3063)
69a17d6
@muenchdo muenchdo mentioned this issue Dec 9, 2024
Merged
@krancour krancour added this to the v1.2.0 milestone Dec 9, 2024
@krancour krancour mentioned this issue Dec 9, 2024
Closed
3 tasks
muenchdo added a commit to muenchdo/kargo that referenced this issue Dec 9, 2024
@muenchdo
feat: custom PR title (akuity#3063)
000de72 
Signed-off-by: Dominik Münch <d.muench@celonis.com>
muenchdo added a commit to muenchdo/kargo that referenced this issue Dec 9, 2024
@muenchdo
feat: custom PR title (akuity#3063)
a099603 
Signed-off-by: Dominik Münch <d.muench@celonis.com>
muenchdo added a commit to muenchdo/kargo that referenced this issue Dec 9, 2024
@muenchdo
feat: custom PR title (akuity#3063)
4ed8dcb 
Signed-off-by: Dominik Münch <d.muench@celonis.com>
github-merge-queue bot pushed a commit that referenced this issue Dec 9, 2024
@muenchdo
feat: custom PR title (#3063) (#3107)
ad9e16f 
Signed-off-by: Dominik Münch <d.muench@celonis.com>
fykaa pushed a commit to fykaa/kargo that referenced this issue Dec 20, 2024
@muenchdo @fykaa
feat: custom PR title (akuity#3063) (akuity#3107)
f275629 
Signed-off-by: Dominik Münch <d.muench@celonis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krancour krancour

@mmclane mmclane

Labels
area/controller help-wanted Community help on this would be appreciated kind/enhancement priority/normal size/medium
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

feat: custom PR title (#3063) muenchdo/kargo
2 participants
@krancour @mmclane