Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add notes about pkce in values.yaml #976

Closed
krancour opened this issue Oct 17, 2023 · 0 comments · Fixed by #980
Closed

add notes about pkce in values.yaml #976

krancour opened this issue Oct 17, 2023 · 0 comments · Fixed by #980
Labels
area/charts area/documentation good first issue Good issue for a new contributor to handle hacktoberfest kind/chore priority/normal
Milestone
v0.2.0

Comments

@krancour
Copy link
Member

values.yaml would do well to have some comments explaining that Kargo uses OIDC with PKCE. This newer OIDC workflow is not familiar to everyone. Some links that explain PKCE might also be helpful.
@krancour krancour added this to the v0.2.0 milestone Oct 17, 2023
smolinari added a commit to smolinari/kargo that referenced this issue Oct 18, 2023
@smolinari
fix:(helm charts): add notes about pkce in values.yaml akuity#976
c1d90e3
smolinari added a commit to smolinari/kargo that referenced this issue Oct 18, 2023
@smolinari
fix:(helm charts): add notes about pkce in values.yaml akuity#976
b555c8a 
Signed-off-by: Scott <smolinari@users.noreply.github.com>
smolinari added a commit to smolinari/kargo that referenced this issue Oct 18, 2023
@smolinari
fix:(helm charts): add notes about pkce in values.yaml akuity#976
fab18c4 
Signed-off-by: Scott <smolinari@users.noreply.github.com>
@krancour krancour mentioned this issue Oct 18, 2023
Merged
krancour added a commit that referenced this issue Oct 18, 2023
@smolinari @krancour
fix:(helm charts): add notes about pkce in values.yaml #976 (#980)
4050c13 
Signed-off-by: Scott <smolinari@users.noreply.github.com>
Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/charts area/documentation good first issue Good issue for a new contributor to handle hacktoberfest kind/chore priority/normal
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

fix:(helm charts): add notes about pkce in values.yaml #976 smolinari/kargo
1 participant
@krancour