Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unstable nightly builds #1017

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Conversation

34fathombelow
Copy link
Member

This PR will build container images and helm-charts daily from the main branch ( M-Fri). The format for the unstable builds will be v0.1.2-unstable-20231023.

Unstable CLI binaries will come next with the documentation on how to use unstable builds for testing. Once this PR is merged and a build is kicked off at the daily scheduled time of 6P.M. PST you can use the following to get started.

helm install kargo \
oci://ghcr.io/akuity/kargo-charts-unstable/kargo --version 0.1.2-unstable-20231023 \
--namespace kargo \
--create-namespace \
--set image.repository=ghcr.io/akuity/kargo-unstable \
--set api.service.type=NodePort \
--set api.service.nodePort=31444 \
--set api.adminAccount.password=admin \
--set api.adminAccount.tokenSigningKey=iwishtowashmyirishwristwatch \

Signed-off-by: Justin Marquis <justin@akuity.io>
@34fathombelow 34fathombelow requested a review from a team as a code owner October 23, 2023 23:33
@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 7668bb2
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/6537edc5b7768100089ccfc1
😎 Deploy Preview https://deploy-preview-1017.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krancour
Copy link
Member

@34fathombelow thank you for this! This all looks sensible to me. Couple Qs posed inline.

More general... I know you'd asked about the possibility of a separate workflow. I think I might prefer that only because it seems the behavior for the official release vs nightly are more divergent than we maybe anticipated initially. What's your take? If you prefer it as is, I'll go along with it.

Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com>
@34fathombelow
Copy link
Member Author

@34fathombelow thank you for this! This all looks sensible to me. Couple Qs posed inline.

More general... I know you'd asked about the possibility of a separate workflow. I think I might prefer that only because it seems the behavior for the official release vs nightly are more divergent than we maybe anticipated initially. What's your take? If you prefer it as is, I'll go along with it.

I personally do not have a preference. I choose to include it in the release workflow to reduce the maintainability of a separate workflow.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c2479eb) 51.51% compared to head (02ec3cb) 51.51%.

❗ Current head 02ec3cb differs from pull request most recent head 37e5ee7. Consider uploading reports for the commit 37e5ee7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1017   +/-   ##
=======================================
  Coverage   51.51%   51.51%           
=======================================
  Files         104      104           
  Lines        7675     7675           
=======================================
  Hits         3954     3954           
  Misses       3576     3576           
  Partials      145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour
Copy link
Member

Gonna merge this and let'er rip at 13:00. That will validate it all and if we want to refactor a bit later, we can.

@krancour krancour merged commit e9bb4cd into akuity:main Oct 24, 2023
@34fathombelow 34fathombelow deleted the feat/unstable_builds branch July 5, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants