-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unstable nightly builds #1017
Conversation
Signed-off-by: Justin Marquis <justin@akuity.io>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@34fathombelow thank you for this! This all looks sensible to me. Couple Qs posed inline. More general... I know you'd asked about the possibility of a separate workflow. I think I might prefer that only because it seems the behavior for the official release vs nightly are more divergent than we maybe anticipated initially. What's your take? If you prefer it as is, I'll go along with it. |
Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com>
I personally do not have a preference. I choose to include it in the release workflow to reduce the maintainability of a separate workflow. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1017 +/- ##
=======================================
Coverage 51.51% 51.51%
=======================================
Files 104 104
Lines 7675 7675
=======================================
Hits 3954 3954
Misses 3576 3576
Partials 145 145 ☔ View full report in Codecov by Sentry. |
Gonna merge this and let'er rip at 13:00. That will validate it all and if we want to refactor a bit later, we can. |
This PR will build container images and helm-charts daily from the main branch ( M-Fri). The format for the unstable builds will be
v0.1.2-unstable-20231023
.Unstable CLI binaries will come next with the documentation on how to use unstable builds for testing. Once this PR is merged and a build is kicked off at the daily scheduled time of 6P.M. PST you can use the following to get started.