Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CRUD/Refresh Warehouse endpoints #1055

Merged
merged 6 commits into from
Nov 2, 2023
Merged

feat: add CRUD/Refresh Warehouse endpoints #1055

merged 6 commits into from
Nov 2, 2023

Conversation

devholic
Copy link
Contributor

@devholic devholic commented Nov 2, 2023

Resolves #977

Sunghoon Kang added 5 commits November 2, 2023 09:44
Signed-off-by: Sunghoon Kang <hoon@akuity.io>
Signed-off-by: Sunghoon Kang <hoon@akuity.io>
Signed-off-by: Sunghoon Kang <hoon@akuity.io>
Signed-off-by: Sunghoon Kang <hoon@akuity.io>
@devholic devholic requested a review from a team as a code owner November 2, 2023 03:13
Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit fa5c997
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/65432643e7b0ff0008836674
😎 Deploy Preview https://deploy-preview-1055.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 170 lines in your changes are missing coverage. Please review.

Comparison is base (958747d) 51.83% compared to head (fa5c997) 50.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1055      +/-   ##
==========================================
- Coverage   51.83%   50.87%   -0.97%     
==========================================
  Files         106      113       +7     
  Lines        7802     7975     +173     
==========================================
+ Hits         4044     4057      +13     
- Misses       3612     3772     +160     
  Partials      146      146              
Files Coverage Δ
api/v1alpha1/helpers.go 100.00% <100.00%> (ø)
internal/api/validators.go 85.45% <0.00%> (-14.55%) ⬇️
api/v1alpha1/stage_helpers.go 17.50% <0.00%> (+0.42%) ⬆️
api/v1alpha1/warehouse_helpers.go 29.16% <0.00%> (-24.68%) ⬇️
internal/api/refresh_warehouse_v1alpha1.go 0.00% <0.00%> (ø)
internal/api/list_warehouses_v1alpha1.go 0.00% <0.00%> (ø)
internal/api/get_warehouse_v1alpha1.go 0.00% <0.00%> (ø)
internal/api/delete_warehouse_v1alpha1.go 0.00% <0.00%> (ø)
internal/api/create_warehouse_v1alpha1.go 0.00% <0.00%> (ø)
internal/api/update_warehouse_v1alpha1.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessesuen
Copy link
Member

jessesuen commented Nov 2, 2023

Could you add a Refresh endpoint and controller implementation similar to how stages can be refreshed? This will be necessary to detect new images/git commits, etc...

Sorry, I'm stupid. I just saw this in the PR.

#1055 (comment)

Signed-off-by: Sunghoon Kang <hoon@akuity.io>
@devholic devholic requested a review from gdsoumya November 2, 2023 04:32
Copy link
Contributor

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devholic devholic merged commit f5679be into main Nov 2, 2023
@devholic devholic deleted the hoon/#977 branch November 2, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add crud + refresh Warehouses endpoints
3 participants