make warehouse do shallow, single-branch clones #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1091 +/- ##
==========================================
- Coverage 50.32% 50.32% -0.01%
==========================================
Files 114 114
Lines 8089 8088 -1
==========================================
- Hits 4071 4070 -1
Misses 3871 3871
Partials 147 147 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kent <kent.rancourt@gmail.com>
krancour
force-pushed
the
krancour/faster-warehouses
branch
from
a24b6c0 to
44931af
Compare
jessesuen
approved these changes
Nov 14, 2023
Comment on lines
+105
to
+108
| // Shallow indicates whether the clone should be with a depth of 1. This is | ||
| // useful for speeding up the cloning process when all we care about is the | ||
| // latest commit from a single branch. | ||
| Shallow bool |
There was a problem hiding this comment.
Since I only see CloneOptions used one place, is it true that this PR makes it such that all clones performed by kargo are shallow?
There was a problem hiding this comment.
No... only the Warehouse reconciler is exercising these options.
The Promotion reconciler still does a full clone (nil options).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1090