Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix infinite promos on error #1103

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

krancour
Copy link
Member

Fixes #1101

Signed-off-by: Kent <kent.rancourt@gmail.com>
Signed-off-by: Kent <kent.rancourt@gmail.com>
Signed-off-by: Kent <kent.rancourt@gmail.com>
@krancour krancour added this to the v0.2.0 milestone Nov 14, 2023
@krancour krancour self-assigned this Nov 14, 2023
@krancour krancour requested a review from a team as a code owner November 14, 2023 17:57
Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 6b4751b
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/6553b4f0cb67940008b0263c
😎 Deploy Preview https://deploy-preview-1103.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krancour krancour added priority/urgent Fix right away and removed priority/high labels Nov 14, 2023
@krancour krancour requested a review from jessesuen November 14, 2023 17:57
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (da810ea) 50.43% compared to head (6b4751b) 50.37%.

Files Patch % Lines
internal/controller/stages/stages.go 56.00% 10 Missing and 1 partial ⚠️
internal/kubeclient/indexer.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1103      +/-   ##
==========================================
- Coverage   50.43%   50.37%   -0.07%     
==========================================
  Files         114      114              
  Lines        8044     8076      +32     
==========================================
+ Hits         4057     4068      +11     
- Misses       3841     3861      +20     
- Partials      146      147       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@krancour krancour merged commit 70ce9f1 into akuity:main Nov 14, 2023
17 of 19 checks passed
@krancour krancour deleted the krancour/fix-infinite-promos branch November 14, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: infinite failed promotions
2 participants