Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add delete freight endpoint to api server #1177

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

devholic
Copy link
Contributor

Resolves #1071

Resolves #1071

Signed-off-by: Sunghoon Kang <hoon@akuity.io>
Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 1884d23
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/6566b61cf8c97a00082963be
😎 Deploy Preview https://deploy-preview-1177.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (a569a42) 48.83% compared to head (1884d23) 48.67%.

Files Patch % Lines
internal/api/delete_freight_v1alpha1.go 0.00% 21 Missing ⚠️
internal/api/validators.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1177      +/-   ##
==========================================
- Coverage   48.83%   48.67%   -0.17%     
==========================================
  Files         115      116       +1     
  Lines        8573     8602      +29     
==========================================
  Hits         4187     4187              
- Misses       4234     4263      +29     
  Partials      152      152              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

#1177 (comment)

Signed-off-by: Sunghoon Kang <hoon@akuity.io>
@devholic devholic requested a review from krancour November 29, 2023 03:55
Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devholic devholic added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit 8d9ab31 Nov 29, 2023
12 of 14 checks passed
@devholic devholic deleted the hoon/#1071-api branch November 29, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api server needs endpoint for deleting freight
2 participants