feat: display alias names in UI #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rbreeze
commented
Nov 29, 2023
rbreeze
commented
Signed-off-by: Remington Breeze <remington@breeze.software>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Remington Breeze <remington@breeze.software>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1180 +/- ##
=======================================
Coverage 48.67% 48.67%
=======================================
Files 116 116
Lines 8602 8602
=======================================
Hits 4187 4187
Misses 4263 4263
Partials 152 152 ☔ View full report in Codecov by Sentry. |
rbreeze
commented
Nov 29, 2023
| @@ -46,29 +49,29 @@ export const StageNode = ({ | |||
| }} | |||
| > | |||
| <h3 className='flex items-center text-white justify-between'> | |||
| <div className='text-ellipsis whitespace-nowrap overflow-hidden'> | |||
| {stage.metadata?.name} | |||
| <div className='truncate pb-1'>{stage.metadata?.name}</div> | |||
There was a problem hiding this comment.
truncate is identical to text-ellipsis whitespace-nowrap overflow-hidden.
pb-1 is added to prevent descender letters (e.g. g, j, p) from being cut off at the bottom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.