fix(ui): clarify why freight is available for promotion #1181
Conversation
Signed-off-by: Remington Breeze <remington@breeze.software>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -117,7 +117,7 @@ const Nodule = (props: { | |||
| left: props.begin ? -noduleHeight / 2 : 'auto', | |||
| right: props.begin ? 'auto' : -noduleHeight / 2 | |||
| }} | |||
| className={`z-10 flex items-center justify-center hover:text-white border border-sky-300 border-solid hover:bg-blue-400 absolute rounded-lg ${ | |||
| className={`select-none z-10 flex items-center justify-center hover:text-white border border-sky-300 border-solid hover:bg-blue-400 absolute rounded-lg ${ | |||
There was a problem hiding this comment.
Prevents the button text from being selected when clicking repeatedly
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1181 +/- ##
==========================================
- Coverage 48.67% 48.56% -0.11%
==========================================
Files 116 117 +1
Lines 8602 8660 +58
==========================================
+ Hits 4187 4206 +19
- Misses 4263 4302 +39
Partials 152 152 ☔ View full report in Codecov by Sentry. |
|
@rbreeze I like the presentation. I only want to suggest some rewording. We recently stopped using "qualified" because the meaning was too ambiguous. "Qualified in" and "qualified for" would both be reasonable interpretations of "qualified" and have very different meanings. You probably recall that convo... We subsequently shifted to using "verified in" and "approved for," so the following would be more accurate:
For promote to subscribers, the changes needed are less extensive:
But are these too wordy? 🤔 I welcome further tweaks. |
|
@krancour Thanks for the reminder, I forgot about the wording change 😄 Both of those sound good to me. There's a lot of real estate to show the message, and given that most people will either read it once or not at all, I don't think it's too wordy. In fact, that gives me an idea for a future improvement to this: the option to dismiss the banner once you've read it. And perhaps a question mark button to bring it back. I'll open an issue to track |
Signed-off-by: Remington Breeze <remington@breeze.software>
Fixes #1158