Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add link to external CRD reference #1194

Merged
merged 2 commits into from
Nov 30, 2023
Merged

docs: add link to external CRD reference #1194

merged 2 commits into from
Nov 30, 2023

Conversation

morey-tech
Copy link
Contributor

@morey-tech morey-tech commented Nov 30, 2023

Add a link to external CRD reference to docs sidebar. Interim solution for #719

Xnapper-2023-11-30-12 36 19

Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit e0efff6
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/6568c970ce6ef10009554ca3
😎 Deploy Preview https://deploy-preview-1194.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (591e1d8) 48.08% compared to head (e0efff6) 48.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1194   +/-   ##
=======================================
  Coverage   48.08%   48.08%           
=======================================
  Files         118      118           
  Lines        8747     8747           
=======================================
  Hits         4206     4206           
  Misses       4389     4389           
  Partials      152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Nicholas Morey <nicholas@morey.tech>
@morey-tech morey-tech marked this pull request as ready for review November 30, 2023 17:48
@morey-tech morey-tech requested review from a team as code owners November 30, 2023 17:48
Copy link
Member

@christianh814 christianh814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Simple and good short-term solution

@krancour krancour added this pull request to the merge queue Nov 30, 2023
@krancour
Copy link
Member

Thanks @morey-tech !

Merged via the queue into main with commit d639370 Nov 30, 2023
14 checks passed
@krancour krancour deleted the add-crd-ref-sidebar branch November 30, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants