Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch docs from yarn to pnpm #1201

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

krancour
Copy link
Member

@krancour krancour commented Dec 1, 2023

We use pnpm everywhere else in the project.

Figured this makes things just a smidge easier.

Used pnpm import for the migration, so we should be pinned to all the exact same versions that yarn.lock files pinned us to.

Signed-off-by: Kent <kent.rancourt@gmail.com>
@krancour krancour requested review from a team as code owners December 1, 2023 00:05
Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit bae7688
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/6569233f0b329b000831acc1
😎 Deploy Preview https://deploy-preview-1201.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (122b81a) 48.08% compared to head (bae7688) 48.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1201   +/-   ##
=======================================
  Coverage   48.08%   48.08%           
=======================================
  Files         118      118           
  Lines        8747     8747           
=======================================
  Hits         4206     4206           
  Misses       4389     4389           
  Partials      152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@devholic devholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this PR switches docs from yarn to pnpm 😅

@krancour krancour changed the title switch docs from pnpm to yarn switch docs from yarn to pnpm Dec 1, 2023
@krancour
Copy link
Member Author

krancour commented Dec 1, 2023

@devholic yep... I got the title backwards, didn't I?

Thank you for noticing.

Fixed!

@krancour krancour added this pull request to the merge queue Dec 1, 2023
Merged via the queue into akuity:main with commit af2d79a Dec 1, 2023
17 checks passed
@krancour krancour deleted the krancour/no-more-yarn branch December 1, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants