add alias column when printing freight with kubectl #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kent <kent.rancourt@gmail.com>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Kent <kent.rancourt@gmail.com>
Signed-off-by: Kent <kent.rancourt@gmail.com>
Signed-off-by: Kent <kent.rancourt@gmail.com>
krancour
force-pushed
the
krancour/alias-fixes
branch
from
983da4d to
c03ef0b
Compare
krancour
commented
Dec 1, 2023
| @@ -11,6 +11,8 @@ import ( | |||
|
|
|||
| //+kubebuilder:object:root=true | |||
| //+kubebuilder:subresource:status | |||
| //+kubebuilder:printcolumn:name=Alias,type=string,JSONPath=`.metadata.labels.kargo\.akuity\.io/alias` | |||
| //+kubebuilder:printcolumn:name=Age,type=date,JSONPath=`.metadata.creationTimestamp` | |||
There was a problem hiding this comment.
Once you add any column, you're responsible for all of them, except for Name.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1203 +/- ##
=======================================
Coverage 48.08% 48.08%
=======================================
Files 118 118
Lines 8747 8747
=======================================
Hits 4206 4206
Misses 4389 4389
Partials 152 152 ☔ View full report in Codecov by Sentry. |
gdsoumya
approved these changes
Dec 1, 2023
jessesuen
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1198 and another embarrassing issue: s/akuity.com/akuity.io/ in alias label key.