Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to disable liveness and readiness probes #1218

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

krancour
Copy link
Member

@krancour krancour commented Dec 3, 2023

This option is useful when developing in a local cluster.

This PR also disables probes when using Tilt to run in a local cluster. It makes things come up quite a bit faster.

Signed-off-by: Kent <kent.rancourt@gmail.com>
Signed-off-by: Kent <kent.rancourt@gmail.com>
Signed-off-by: Kent <kent.rancourt@gmail.com>
@krancour krancour requested a review from a team as a code owner December 3, 2023 22:21
Copy link

netlify bot commented Dec 3, 2023

Deploy Preview for docs-kargo-akuity-io failed.

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/656d1a359cf6c76129d9d533

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c2fce9) 48.08% compared to head (0a9c5da) 48.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1218   +/-   ##
=======================================
  Coverage   48.08%   48.08%           
=======================================
  Files         118      118           
  Lines        8747     8747           
=======================================
  Hits         4206     4206           
  Misses       4389     4389           
  Partials      152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krancour krancour added this pull request to the merge queue Dec 5, 2023
Merged via the queue into akuity:main with commit 56b98e8 Dec 5, 2023
17 of 20 checks passed
@krancour krancour deleted the krancour/disable-probes-option branch December 5, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants