Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate remaining go mod dependencies on argo cd and gitops engine #1235

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

krancour
Copy link
Member

@krancour krancour commented Dec 6, 2023

Fixes #956

This has been a long time coming. This PR removes the last of our Go mod dependencies on Argo CD and GitOps Engine.

With it, we also say goodbye to a litany of transitive dependencies.

This should make it considerably easier to upgrade the modules we do care about.

Signed-off-by: Kent <kent.rancourt@gmail.com>
Signed-off-by: Kent <kent.rancourt@gmail.com>
@krancour krancour added this to the v0.3.0 milestone Dec 6, 2023
@krancour krancour self-assigned this Dec 6, 2023
@krancour krancour requested a review from a team as a code owner December 6, 2023 14:47
Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit efb7185
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/6570cfd887358a0008ba369c
😎 Deploy Preview https://deploy-preview-1235.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krancour krancour changed the title Krancour/goodbye unwanted deps eliminate remaining go mod dependencies on argo cd and gitops engine Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (369fa29) 48.37% compared to head (efb7185) 48.37%.
Report is 3 commits behind head on main.

Files Patch % Lines
internal/credentials/credentials.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1235   +/-   ##
=======================================
  Coverage   48.37%   48.37%           
=======================================
  Files         127      127           
  Lines        9632     9632           
=======================================
  Hits         4659     4659           
  Misses       4812     4812           
  Partials      161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour enabled auto-merge December 6, 2023 18:08
Signed-off-by: Kent <kent.rancourt@gmail.com>
@krancour krancour added this pull request to the merge queue Dec 6, 2023
Merged via the queue into akuity:main with commit 71848ca Dec 6, 2023
13 of 14 checks passed
@krancour krancour deleted the krancour/goodbye-unwanted-deps branch December 6, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

break go mod dependency on argo cd and gitops engine
3 participants