feat(api): add interceptor to bubble up underlying error code

[devholic]

Resolves #1215

[netlify]

✅ Deploy Preview for docs-kargo-akuity-io ready!

Name	Link
🔨 Latest commit	7c0294f
🔍 Latest deploy log	https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/659d0481d5d2a70008bf7b04
😎 Deploy Preview	https://deploy-preview-1266.kargo.akuity.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

Attention: 77 lines in your changes are missing coverage. Please review.

Comparison is base (c343c41) 45.56% compared to head (7c0294f) 45.31%.
Report is 12 commits behind head on main.

Files	Patch %	Lines
internal/api/option/error.go	39.65%	34 Missing and 1 partial ⚠️
internal/api/delete_stage_v1alpha1.go	0.00%	4 Missing ⚠️
internal/api/approve_freight_v1alpha1.go	0.00%	3 Missing ⚠️
...ernal/api/set_auto_promotion_for_stage_v1alpha1.go	0.00%	3 Missing ⚠️
internal/api/create_project_v1alpha1.go	0.00%	2 Missing ⚠️
internal/api/delete_project_v1alpha1.go	0.00%	2 Missing ⚠️
internal/api/delete_promotion_policy_v1alpha1.go	0.00%	2 Missing ⚠️
internal/api/delete_warehouse_v1alpha1.go	0.00%	2 Missing ⚠️
internal/api/option/option.go	0.00%	2 Missing ⚠️
internal/api/update_promotion_policy_v1alpha1.go	0.00%	2 Missing ⚠️
... and 18 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1266      +/-   ##
==========================================
- Coverage   45.56%   45.31%   -0.25%     
==========================================
  Files         135      137       +2     
  Lines       11657    11791     +134     
==========================================
+ Hits         5311     5343      +32     
- Misses       6155     6256     +101     
- Partials      191      192       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[devholic]

@krancour Changed interceptor to wrap error if the given error is unknown connect error or plain go error

[krancour]

@devholic it also looks like there might be several remaining cases where a handler does a apierrors.IsNotFound(err) test to explicitly return a connect error with connect.CodeNotFound.

That explicit handling can be removed now, right?

[devholic]

@devholic it also looks like there might be several remaining cases where a handler does a apierrors.IsNotFound(err) test to explicitly return a connect error with connect.CodeNotFound.

That explicit handling can be removed now, right?

@krancour I'm still not sure whether it's okay to remove explicit error handling in handlers.

• Each handler tests will be affected by interceptors.
  • If there are changes in interceptors, all handler test cases can be affected (where checking status code)
• There can be an inconsistency when writing handler test codes - to check returned error types

[krancour]

Each handler tests will be affected by interceptors

@devholic handlers should be tested independently of any interceptors.

[krancour]

Code looks good @devholic. I'm going to test drive e2e Monday morning.

[krancour]

I tried this with a variety of error cases just now. Overall, it's working great, but I did notice that 422 (unprocessable content/entity) is something k8s may sometimes return when, for instance, a webhook or other admission control has found something invalid in a resource, but that's a status code the interceptor isn't mapping.

@devholic I think maybe we should handle that case the same as "bad request." I couldn't find a connect error code that was a better mapping than that.

Easy way to see this in action is through kargo create project FOO, which will fail because Kubernetes doesn't like caps in resource names. Right now it comes through as an internal error due to lack of mapping mentioned above.

[krancour]

This now shows the anticipated error type for every error I've been able to force. 🔥

Thank you @devholic!