fix(controller): make tag selector ignore references in an oci image index that don't look like they refer to an image #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1268 +/- ##
=======================================
Coverage 48.50% 48.50%
=======================================
Files 127 127
Lines 9675 9683 +8
=======================================
+ Hits 4693 4697 +4
- Misses 4823 4826 +3
- Partials 159 160 +1 ☔ View full report in Codecov by Sentry. |
jessesuen
reviewed
Dec 12, 2023
Comment on lines
21
to
22
| const guestbookRepo = "ghcr.io/jessesuen/guestbook" | ||
| const guestbookTag = "v0.0.47" |
There was a problem hiding this comment.
Hmm, I'd like the freedom to delete this repo without breaking tests. I've repushed this multi-arch image as: ghcr.io/akuity/kargo-test:unknown. Can we change this to use that?
https://github.com/orgs/akuity/packages/container/kargo-test/156938778?tag=unknown
jessesuen
approved these changes
Dec 12, 2023
Signed-off-by: Kent <kent.rancourt@gmail.com>
krancour
force-pushed
the
krancour/tag-selector-test-fixes
branch
from
4ddadf4 to
8bd32c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1267