Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eliminate double reconcile during refresh requests #1279

Merged
merged 1 commit into from
Dec 14, 2023
Merged

fix: eliminate double reconcile during refresh requests #1279

merged 1 commit into from
Dec 14, 2023

Conversation

jessesuen
Copy link
Member

@jessesuen jessesuen commented Dec 14, 2023 •
edited
Loading

Currently when someone clicks refresh on a Stage, Warehouse, we get two reconciles:

  1. first reconcile happens because refresh annotation was set by kargo-api
  2. second reconcile happens because controller patches the objects annotation to clear the refresh annotation

This introduces a predicate which will filter out the event if the update event was to clear the annotation, preventing the second reconcile.

@jessesuen
fix: eliminate double reconcile during refresh requests
3088af8 
Signed-off-by: Jesse Suen <jesse@akuity.io>
@jessesuen jessesuen requested a review from a team as a code owner December 14, 2023 22:17
@netlify Netlify
Copy link

netlify bot commented Dec 14, 2023 •
edited
Loading

❌ Deploy Preview for docs-kargo-akuity-io failed.

Name Link
🔨 Latest commit 3088af8
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/657b7f00bf21940008052dbd

krancour
krancour approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@jessesuen jessesuen added this pull request to the merge queue Dec 14, 2023
Merged via the queue into akuity:main with commit e3e2c1f Dec 14, 2023
14 of 17 checks passed
@jessesuen jessesuen deleted the fix/refresh-double-reconcile branch December 14, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krancour krancour krancour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessesuen @krancour