Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): ensure warehouses and running promotions are routinely re-reconciled #1311

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

krancour
Copy link
Member

Fixes #1192

@krancour krancour added this to the v0.3.0 milestone Dec 20, 2023
@krancour krancour self-assigned this Dec 20, 2023
@krancour krancour requested a review from a team as a code owner December 20, 2023 20:20
Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 338971d
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/65834d0c62e34d00089b762e
😎 Deploy Preview https://deploy-preview-1311.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour force-pushed the krancour/routine-reconciles branch from abfa0e5 to 338971d Compare December 20, 2023 20:22
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (2571671) 45.85% compared to head (338971d) 45.82%.

Files Patch % Lines
internal/controller/promotions/promotions.go 30.00% 6 Missing and 1 partial ⚠️
internal/controller/warehouses/warehouses.go 0.00% 3 Missing ⚠️
internal/controller/stages/stages.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1311      +/-   ##
==========================================
- Coverage   45.85%   45.82%   -0.03%     
==========================================
  Files         135      135              
  Lines       11545    11556      +11     
==========================================
+ Hits         5294     5296       +2     
- Misses       6061     6069       +8     
- Partials      190      191       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour enabled auto-merge December 20, 2023 20:26
@krancour krancour added this pull request to the merge queue Dec 20, 2023
Merged via the queue into akuity:main with commit a2f6889 Dec 20, 2023
13 of 15 checks passed
@krancour krancour deleted the krancour/routine-reconciles branch December 20, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warehouse did not detect new image automatically (without manual refresh)
2 participants