fix: sort promotions with running and pending first #1314
Conversation
Signed-off-by: Remington Breeze <remington@breeze.software>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| running10, | ||
| running8, | ||
| running3, | ||
| running1, | ||
| pending11, | ||
| pending9, | ||
| pending4, | ||
| pending2, | ||
| unknown14, | ||
| errored13, | ||
| succeeded12, | ||
| unknown7, | ||
| failed6, | ||
| succeeded5 |
There was a problem hiding this comment.
Running promotions come first, sorted by timestamp. Then pending promotions, also sorted by timestamp, and finally everything else sorted by timestamp.
| <Popover | ||
| content={promotion.status?.message} | ||
| title={promotion.status?.phase} | ||
| placement='right' | ||
| > |
There was a problem hiding this comment.
Nothing changed here, just ran Prettier
| <Popover | ||
| content={promotion.status?.message} | ||
| title={promotion.status?.phase} | ||
| placement='right' | ||
| > |
There was a problem hiding this comment.
Same here, Prettier fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1314 +/- ##
=======================================
Coverage 45.82% 45.82%
=======================================
Files 135 135
Lines 11556 11556
=======================================
Hits 5296 5296
Misses 6069 6069
Partials 191 191 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
We'll eventually want the running promotion displayed prominently, e.g. with details to the PR, etc... Also there can only be on running promo at a time so we can reserve special place in the UI for it.
EDIT: I just saw your comment. But yes that can be a different issue.
@jessesuen In the issue above, you mentioned a special section for currently running promotions. This seems like a separate issue to me, but I'm happy to keep the above issue open if you prefer to track it there
Fixes #1037
@jessesuen In the issue above, you mentioned adding a special section in the UI for currently running promotions. This seems like a separate issue to me, but I'm happy to keep the above issue open if you prefer to track it there