Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): hovering on a DAG node would highlight other nodes with same freight #1316

Merged
merged 4 commits into from
Dec 22, 2023
Merged

fix(ui): hovering on a DAG node would highlight other nodes with same freight #1316

merged 4 commits into from
Dec 22, 2023

Conversation

rbreeze
Copy link
Contributor

@rbreeze rbreeze commented Dec 21, 2023

Before:
CleanShot 2023-12-21 at 12 38 04@2x

After:
CleanShot 2023-12-21 at 12 37 46@2x

@rbreeze
fix: hovering on a DAG node would highlight other nodes with same fre…
6ea8348 
…ight

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from a team as a code owner December 21, 2023 20:38
@netlify Netlify
Copy link

netlify bot commented Dec 21, 2023 •
edited
Loading

✅ Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 6ea8348
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/6584a24c01f7a800081318a9
😎 Deploy Preview https://deploy-preview-1316.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Dec 21, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5570d77) 45.82% compared to head (348a484) 45.82%.
Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1316   +/-   ##
=======================================
  Coverage   45.82%   45.82%           
=======================================
  Files         135      135           
  Lines       11556    11556           
=======================================
  Hits         5296     5296           
  Misses       6069     6069           
  Partials      191      191

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbreeze rbreeze changed the base branch from main to release-0.3 December 21, 2023 22:35
@krancour krancour added this to the v0.4.0 milestone Dec 22, 2023
@krancour krancour changed the base branch from release-0.3 to main December 22, 2023 18:03
@krancour krancour changed the title fix: hovering on a DAG node would highlight other nodes with same freight feat(ui): hovering on a DAG node would highlight other nodes with same freight Dec 22, 2023
@krancour krancour changed the title feat(ui): hovering on a DAG node would highlight other nodes with same freight fix(ui): hovering on a DAG node would highlight other nodes with same freight Dec 22, 2023
krancour
krancour approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test drove. LGTM

@rbreeze rbreeze added this pull request to the merge queue Dec 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 22, 2023
@rbreeze rbreeze added this pull request to the merge queue Dec 22, 2023
Merged via the queue into main with commit 9063001 Dec 22, 2023
20 checks passed
@rbreeze rbreeze deleted the hover-group-fix branch December 22, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krancour krancour krancour approved these changes

Assignees

@rbreeze rbreeze

Labels
area/ui kind/bug priority/normal
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rbreeze @krancour