chore(dependencies): upgrade controller runtime and all things k8s #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1317 +/- ##
==========================================
- Coverage 45.82% 45.55% -0.28%
==========================================
Files 135 135
Lines 11556 11637 +81
==========================================
+ Hits 5296 5301 +5
- Misses 6069 6145 +76
Partials 191 191 ☔ View full report in Codecov by Sentry. |
krancour
commented
Dec 21, 2023
Comment on lines
+88
to
+90
| source.Kind(kargoMgr.GetCache(), | ||
| &kargoapi.Promotion{}, | ||
| ), |
There was a problem hiding this comment.
@jessesuen this is what I was talking about... the fact that you have to pick a cache (which is a wrapper around a client) when you call Watch makes me suspect we may be able to create controllers that reconcile using one client, but also watch things using another. (Useful for sharding.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting v0.4.0 off with a 💥.