Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): support git repos with self-signed cert #1366

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

krancour
Copy link
Member

@krancour krancour commented Jan 4, 2024

Fixes #1224

I verified this against gitea in a local cluster with ingress and a self-signed cert.

Worked as expected.

cc @geowalrus4gh, I think you were looking for this.

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit e5c2a93
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/65972b93f002db00085c943c
😎 Deploy Preview https://deploy-preview-1366.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bdc19b2) 45.56% compared to head (e5c2a93) 45.59%.
Report is 1 commits behind head on main.

Files Patch % Lines
internal/controller/warehouses/git.go 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1366      +/-   ##
==========================================
+ Coverage   45.56%   45.59%   +0.03%     
==========================================
  Files         135      135              
  Lines       11657    11664       +7     
==========================================
+ Hits         5311     5318       +7     
  Misses       6155     6155              
  Partials      191      191              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krancour krancour added this pull request to the merge queue Jan 5, 2024
Merged via the queue into akuity:main with commit 531a42d Jan 5, 2024
22 checks passed
@krancour krancour deleted the krancour/git-ignore-tls branch January 5, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Self signed https git repo
2 participants