Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): remove superfluous detail from quickstart #1374

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

krancour
Copy link
Member

@krancour krancour commented Jan 6, 2024

This is leftover from when the quickstart used to borrow a secret from Argo CD.

The quickstart no longer demonstrates that behavior, so the field removed by this PR was a useless detail and a distraction.

@krancour krancour requested review from a team as code owners January 6, 2024 00:24
Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit cec93dd
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/65989e763c5e180008f46bed
😎 Deploy Preview https://deploy-preview-1374.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (531a42d) 45.59% compared to head (cec93dd) 45.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1374   +/-   ##
=======================================
  Coverage   45.59%   45.59%           
=======================================
  Files         135      135           
  Lines       11664    11664           
=======================================
  Hits         5318     5318           
  Misses       6155     6155           
  Partials      191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this pull request to the merge queue Jan 6, 2024
Merged via the queue into main with commit f369fbe Jan 6, 2024
16 checks passed
@krancour krancour deleted the krancour-patch-1 branch January 6, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants