feat(cli): Add kargo dashboard command #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1433 +/- ##
=======================================
Coverage 47.76% 47.76%
=======================================
Files 140 140
Lines 12124 12124
=======================================
Hits 5791 5791
Misses 6132 6132
Partials 201 201 ☔ View full report in Codecov by Sentry. |
krancour
reviewed
Jan 27, 2024
krancour
reviewed
Jan 27, 2024
|
@webstradev I made two minor suggestions about wording, but all the code LGTM. Thank you! |
Signed-off-by: Erik Westra <e.s.westra.95@gmail.com>
Thanks for that, resolved both comments ( rebased off main as well to keep the history clean) |
|
@webstradev thanks! For future reference, we squash merge, so don't worry too much about commit history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #549 .
Just to note this will not work in development when using tilt (it won't break but it will open the API Url which in the Tilt method is not currently the URL for the dashboard).