feat: allow warehouse git subs to select commits by tag #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1446 +/- ##
==========================================
+ Coverage 48.31% 48.77% +0.46%
==========================================
Files 131 131
Lines 11894 12026 +132
==========================================
+ Hits 5746 5866 +120
- Misses 5948 5959 +11
- Partials 200 201 +1 ☔ View full report in Codecov by Sentry. |
krancour
force-pushed
the
krancour/git-filters
branch
from
a6887ea to
516a960
Compare
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
krancour
force-pushed
the
krancour/git-filters
branch
from
516a960 to
d3262a6
Compare
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
christianh814
approved these changes
Feb 1, 2024
jessesuen
reviewed
Feb 2, 2024
Comment on lines
+106
to
+113
| // IgnoreTags is a list of tags that must be ignored when determining the | ||
| // newest commit of interest. No regular expressions or glob patterns are | ||
| // supported yet. The value in this field only has any effect when the | ||
| // CommitSelectionStrategy is Lexical, NewestTag, or SemVer. This field is | ||
| // optional. | ||
| // | ||
| //+kubebuilder:validation:Optional | ||
| IgnoreTags []string `json:"ignoreTags,omitempty"` |
There was a problem hiding this comment.
I question the need for ignoreTags, when:
- allowTags is a regular expression. And exclusion would be possible with a "negative lookahead":
https://stackoverflow.com/a/2078953 - The fact that ignoreTags is a list of explicit strings, whereas allowTags is a regexp, making them not symetrical. If we do decide to support ignoreTags, I would have expected that to be a regexp.
There was a problem hiding this comment.
Discussed offline. Image tag selection already has this feature and so it's worthwhile to offer the same with git.
|
@jessesuen thank you so much for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #816
This is much smaller than it looks once you ignore codegen.
This works similarly to image selection by tag: