-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: play nicer with helm #1450
Conversation
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1450 +/- ##
==========================================
+ Coverage 48.77% 48.84% +0.06%
==========================================
Files 131 131
Lines 12026 12087 +61
==========================================
+ Hits 5866 5904 +38
- Misses 5959 5978 +19
- Partials 201 205 +4 ☔ View full report in Codecov by Sentry. |
8523cbf
to
ff26e0f
Compare
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
48383bc
to
683b7ac
Compare
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
bb2c5a2
to
fb315d8
Compare
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
fb315d8
to
39c178f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement
Fixes #1281
May partially address #1280, although some aspects of that issue are strictly UI-related.
Supersedes #1294
Draft because I am still working out some kinks.
Summary
With respect to Helm charts, the term "registry" has proven intuitive to people very familiar with OCI registries, but much more befuddling to those who are more familiar with classic (https/s-based) chart repositories. Confusion is compounded by Argo CD and Helm itself (e.g. in dependencies section of a
chart.yaml
file) continuing to exclusively use the classic repository parlance.This PR implements a strategy refined through extensive discussion in #1294 and strikes "registry" from the Kargo vernacular.
When subscribing a warehouse to a chart repo you:
When defining promotion mechanisms:
chart.yaml
simply require you to matchrepository
andname
fields exactly as they appear in thechart.yaml
. Kargo will figure out the rest.Application
source require you to match therepoURL
andchart
fields exactly as they appear in theApplication
source.Incidentally, this PR also changes some function names that contained the phrase "getLatestChart" to "selectChart." "Latest" implies something that isn't necessarily true since chart selection can be constrained with semver constraints.