fix: transform uname arch into valid Go arch #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On an AMD64 system, `uname -m` will return `x86_64` instead of the Go accepted `amd64`. Detect when this is returned (or provided), and overwrite it with the correct value. This ensures the `build-cli` Make target actually works on AMD64 Linux systems. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Nice catch. We accounted for this in CLI installation docs and missed it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On an AMD64 system,
uname -mwill returnx86_64instead of the Go acceptedamd64. Detect when this is returned (or provided), and overwrite it with the correct value.This ensures the
build-cliMake target actually works on AMD64 Linux systems.