Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api)!: make Kubebuilder types protobuf compatible #1515

Merged
merged 24 commits into from
Mar 8, 2024

Merge branch 'main' into devholic/#708

c88f41b
Select commit
Loading
Failed to load commit list.
Merged

refactor(api)!: make Kubebuilder types protobuf compatible #1515

Merge branch 'main' into devholic/#708
c88f41b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 8, 2024 in 0s

21.64% (-9.24%) compared to ae411af

View this Pull Request on Codecov

21.64% (-9.24%) compared to ae411af

Details

Codecov Report

Attention: Patch coverage is 34.52381% with 110 lines in your changes are missing coverage. Please review.

Project coverage is 21.64%. Comparing base (ae411af) to head (c88f41b).

Files Patch % Lines
hack/codegen/prototag/main.go 0.00% 47 Missing ⚠️
internal/proto/codegen/ast.go 73.52% 9 Missing and 9 partials ⚠️
pkg/api/service/v1alpha1/types.go 0.00% 9 Missing ⚠️
internal/cli/cmd/get/freight.go 0.00% 3 Missing ⚠️
internal/api/list_projects_v1alpha1.go 0.00% 2 Missing ⚠️
internal/api/list_promotions_v1alpha1.go 0.00% 2 Missing ⚠️
internal/api/query_freights_v1alpha1.go 60.00% 2 Missing ⚠️
internal/cli/cmd/get/projects.go 0.00% 2 Missing ⚠️
internal/cli/cmd/get/promotions.go 0.00% 2 Missing ⚠️
internal/cli/cmd/get/stages.go 0.00% 2 Missing ⚠️
... and 17 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1515      +/-   ##
==========================================
- Coverage   30.87%   21.64%   -9.24%     
==========================================
  Files         188      187       -1     
  Lines       20162    28040    +7878     
==========================================
- Hits         6226     6068     -158     
- Misses      13652    21701    +8049     
+ Partials      284      271      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov