refactor(crds)!: consistently use message field instead of error field #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1542 +/- ##
=======================================
Coverage 30.05% 30.05%
=======================================
Files 194 194
Lines 20072 20072
=======================================
Hits 6033 6033
Misses 13781 13781
Partials 258 258 ☔ View full report in Codecov by Sentry. |
hiddeco
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jessesuen and I agreed quite some time ago that status subresources would use
Messagefields instead ofErrorfields to preserve the potential for communicating things that are not strictly errors.We have, since then, consistently used
Messagein new status subresource types, but Stages and Warehouses were still usingError.This was a low-hanging consistency improvement that I wanted to make before breaking changes become more difficult.
cc @rbreeze or @rpelczar, although there are open issues for surfacing info from these fields, I can not find any place in the UI where the field names that are changing are currently referenced. You might want to double-check me.
There are no other changes in this PR.