refactor(cli): remove kargo config set|unset in favor of kargo config set-project
#1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a specific command to set the default project, removing the need for the multi-positional `kargo config set` and `kargo config unset` commands. Which at present are only used to configure the default project configuration. Besides this avoiding multi-positional commands, it also improves the documentation in e.g. the `kargo config --help` output to list available configuration options more precisely. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Now that `kargo config set-project` has been introduced. These commands can be removed, as they took multi-positional arguments while the same results can be achieved using the new command. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
krancour
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: #1163 (comment)
This introduces a specific command to set the default project, removing the need for the multi-positional
kargo config setandkargo config unsetcommands. Which at present are only used to configure the default project configuration.Besides this avoiding multi-positional commands, it also improves the documentation in e.g. the
kargo config --helpoutput to list available configuration options more precisely.As
kargo config setandkargo config unsetare now obsolete, they have been removed.