Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): move version command out of root #1556

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Feb 29, 2024

Appears to be a remainder from early days. This puts it in the same module as all other commands, while also changing the code structure to align with recent changes.

Appears to be a remainder from early days. This puts it in the same
module as all other commands, while also changing the code structure
to align with recent changes.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco added this to the v0.5.0 milestone Feb 29, 2024
@hiddeco hiddeco self-assigned this Feb 29, 2024
@hiddeco hiddeco requested a review from a team as a code owner February 29, 2024 20:07
Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 8d7b6eb
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/65e0e414e7f1780008550aa8
😎 Deploy Preview https://deploy-preview-1556.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 75 lines in your changes are missing coverage. Please review.

Project coverage is 30.77%. Comparing base (ab40a6f) to head (8d7b6eb).

Files Patch % Lines
internal/cli/cmd/version/version.go 0.00% 74 Missing ⚠️
cmd/cli/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1556      +/-   ##
==========================================
- Coverage   30.80%   30.77%   -0.03%     
==========================================
  Files         183      183              
  Lines       19389    19403      +14     
==========================================
  Hits         5972     5972              
- Misses      13152    13166      +14     
  Partials      265      265              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddeco hiddeco added this pull request to the merge queue Mar 1, 2024
Merged via the queue into akuity:main with commit f8e9ff9 Mar 1, 2024
18 of 20 checks passed
@hiddeco hiddeco deleted the move-version-cmd branch March 1, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants