Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): bug in updated promotion endpoints #1575

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

krancour
Copy link
Member

@krancour krancour commented Mar 5, 2024

I overlooked that freightName can now be empty if the client provided freightAlias instead.

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour added this to the v0.5.0 milestone Mar 5, 2024
@krancour krancour self-assigned this Mar 5, 2024
@krancour krancour requested a review from a team as a code owner March 5, 2024 17:01
Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 4ce6340
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/65e74fe65f31760008b0d624
😎 Deploy Preview https://deploy-preview-1575.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.15%. Comparing base (87ac85e) to head (4ce6340).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1575   +/-   ##
=======================================
  Coverage   30.15%   30.15%           
=======================================
  Files         185      185           
  Lines       20034    20034           
=======================================
  Hits         6041     6041           
  Misses      13718    13718           
  Partials      275      275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this pull request to the merge queue Mar 5, 2024
Merged via the queue into akuity:main with commit c9aebcd Mar 5, 2024
20 checks passed
@krancour krancour deleted the krancour/promotion-endpoint-fixes branch March 5, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants