Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crds): add shard field to stage spec #1584

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

krancour
Copy link
Member

@krancour krancour commented Mar 6, 2024

Fixes #1582

krancour added 4 commits March 6, 2024 16:00
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit b2e96b8
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/65e8de06a5ed830008f99d45
😎 Deploy Preview https://deploy-preview-1584.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 30.76%. Comparing base (8c5c1ac) to head (b2e96b8).

Files Patch % Lines
pkg/api/v1alpha1/types.pb.go 0.00% 4 Missing ⚠️
internal/webhook/stage/webhook.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1584   +/-   ##
=======================================
  Coverage   30.76%   30.76%           
=======================================
  Files         185      185           
  Lines       20091    20101   +10     
=======================================
+ Hits         6180     6184    +4     
- Misses      13628    13633    +5     
- Partials      283      284    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this pull request to the merge queue Mar 7, 2024
Merged via the queue into akuity:main with commit 74bb750 Mar 7, 2024
21 checks passed
@krancour krancour deleted the krancour/shard-field branch March 7, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add shard field to StageSpec
2 participants