Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor endpoint cleanup #1608

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

krancour
Copy link
Member

Working on resolving merge conflicts in #1566, I noticed some weirdness in existing endpoints.

This PR:

  • Removes unnecessary gets before deletes.
  • Removes unnecessary wrapping of Kubernetes "not found" errors as connect "not found" errors. Our error interceptor is already smart enough to do that. We don't need to do it explicitly.

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour added this to the v0.5.0 milestone Mar 12, 2024
@krancour krancour self-assigned this Mar 12, 2024
@krancour krancour requested a review from a team as a code owner March 12, 2024 19:24
Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 47d0292
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/65f0abf7dd3d53000858c1e3
😎 Deploy Preview https://deploy-preview-1608.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 21.62%. Comparing base (8534a0c) to head (47d0292).

Files Patch % Lines
internal/api/delete_stage_v1alpha1.go 0.00% 9 Missing ⚠️
internal/api/delete_warehouse_v1alpha1.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1608      +/-   ##
==========================================
+ Coverage   21.61%   21.62%   +0.01%     
==========================================
  Files         188      188              
  Lines       27936    27912      -24     
==========================================
  Hits         6037     6037              
+ Misses      21620    21596      -24     
  Partials      279      279              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this pull request to the merge queue Mar 12, 2024
Merged via the queue into akuity:main with commit 11c5939 Mar 12, 2024
19 of 20 checks passed
@krancour krancour deleted the krancour/endpoint-cleanup branch March 12, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants