-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Project creation modal #1626
Conversation
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1626 +/- ##
==========================================
+ Coverage 43.81% 44.10% +0.29%
==========================================
Files 202 202
Lines 12935 13043 +108
==========================================
+ Hits 5667 5753 +86
- Misses 7026 7045 +19
- Partials 242 245 +3 ☔ View full report in Codecov by Sentry. |
Because project creation is mostly just a name, can we also have the default creation UI simply be a text field of the project name? We can still keep this YAML editor as a second tab/option. Other resources like Warehouse, AnalysisTemplate, can just be YAML create wizard. |
@rpelczar this works great, except that I notice the list of projects isn't refreshed after the modal closes. It's also not surfacing an error on an attempt to create a new project with a project name that already exists... but I've discovered that is a back end issue and I'll fix that right away. |
I have fixed this in #1649, but when I test this PR on top of #1649, I notice that even though I can see the error in the console now, it's not being handled or surfaced in the UI. |
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
88aae87
to
9561a18
Compare
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
#1536