Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Project creation modal #1626

Merged
merged 6 commits into from
Mar 24, 2024
Merged

Conversation

rpelczar
Copy link
Contributor

@rpelczar rpelczar commented Mar 14, 2024

@rpelczar rpelczar added this to the v0.5.0 milestone Mar 14, 2024
@rpelczar rpelczar requested a review from a team as a code owner March 14, 2024 21:21
@rpelczar rpelczar linked an issue Mar 14, 2024 that may be closed by this pull request
Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 6bdb8f6
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/65fde5a418f3700008d15aa2
😎 Deploy Preview https://deploy-preview-1626.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 81.19658% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 44.10%. Comparing base (53f5121) to head (6bdb8f6).
Report is 7 commits behind head on main.

Files Patch % Lines
internal/controller/git/git.go 0.00% 14 Missing ⚠️
internal/controller/warehouses/git.go 91.66% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1626      +/-   ##
==========================================
+ Coverage   43.81%   44.10%   +0.29%     
==========================================
  Files         202      202              
  Lines       12935    13043     +108     
==========================================
+ Hits         5667     5753      +86     
- Misses       7026     7045      +19     
- Partials      242      245       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessesuen
Copy link
Member

Because project creation is mostly just a name, can we also have the default creation UI simply be a text field of the project name? We can still keep this YAML editor as a second tab/option.

Other resources like Warehouse, AnalysisTemplate, can just be YAML create wizard.

@krancour
Copy link
Member

@rpelczar this works great, except that I notice the list of projects isn't refreshed after the modal closes.

It's also not surfacing an error on an attempt to create a new project with a project name that already exists... but I've discovered that is a back end issue and I'll fix that right away.

@krancour
Copy link
Member

krancour commented Mar 18, 2024

It's also not surfacing an error on an attempt to create a new project with a project name that already exists... but I've discovered that is a back end issue and I'll fix that right away.

I have fixed this in #1649, but when I test this PR on top of #1649, I notice that even though I can see the error in the console now, it's not being handled or surfaced in the UI.

Signed-off-by: Rafal Pelczar <rafal@akuity.io>
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
@rpelczar rpelczar force-pushed the 1536-project-creation-wizard branch from 88aae87 to 9561a18 Compare March 22, 2024 14:14
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@rpelczar rpelczar requested a review from a team as a code owner March 22, 2024 20:10
@krancour
Copy link
Member

krancour commented Mar 22, 2024

I fixed some conflicts with #1668 in 6bdb8f6

Looking for @rpelczar or @rbreeze to validate my feeble attempt at front end dev.

@krancour krancour added this pull request to the merge queue Mar 24, 2024
Merged via the queue into main with commit b42fa1a Mar 24, 2024
16 checks passed
@krancour krancour deleted the 1536-project-creation-wizard branch March 24, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project creation wizard
3 participants