Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set promotion shard in webhook #1633

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

krancour
Copy link
Member

Fixes #1630

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit ec98337
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/65f4bab3c4f8690007042c27
😎 Deploy Preview https://deploy-preview-1633.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krancour krancour changed the title set promotion shard in webhook feat: set promotion shard in webhook Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 43.95%. Comparing base (f2149ef) to head (ec98337).

Files Patch % Lines
internal/webhook/promotion/webhook.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1633      +/-   ##
==========================================
- Coverage   43.96%   43.95%   -0.02%     
==========================================
  Files         199      199              
  Lines       12673    12674       +1     
==========================================
- Hits         5572     5571       -1     
- Misses       6864     6866       +2     
  Partials      237      237              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this pull request to the merge queue Mar 15, 2024
Merged via the queue into akuity:main with commit e5c4c6f Mar 15, 2024
21 of 22 checks passed
@krancour krancour deleted the krancour/promo-shard-in-webhook branch March 15, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ux: shard label on promos should be set by webhook
2 participants