Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): record verification history Stage #1645

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Mar 18, 2024

Fixes: #1638

This adds a VerificationHistory field to the FreightReference of a Stage, containing a list of the last 10 verification attempts. Technically, I would say this addition makes the VerificationInfo field obsolete. But I kept it for backwards compatibility reasons.

To ensure the AnalysisRun reference for a verification item is always kept around whenever we can (either in the error message, or as AnalysisRunReference), aborting an AnalysisRun will now maintain the reference information.

hiddeco added 3 commits March 18, 2024 13:51
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 2a5017f
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/65f950c5bc4e8d0008a64c7f
😎 Deploy Preview https://deploy-preview-1645.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.15%. Comparing base (1e1e2de) to head (2a5017f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1645      +/-   ##
==========================================
+ Coverage   44.14%   44.15%   +0.01%     
==========================================
  Files         199      199              
  Lines       12728    12790      +62     
==========================================
+ Hits         5619     5648      +29     
- Misses       6868     6900      +32     
- Partials      241      242       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour
Copy link
Member

Technically, I would say this addition makes the VerificationInfo field obsolete. But I kept it for backwards compatibility reasons.

I think that's the right move. Stages have a stack of FreightReferences in their history and the top of that stack always matches what's in the CurrentFreight field. So technically, the CurrentFreight field is redundant... but it was useful to be able to see what the current Freight was without having to know with certainty whether the history used stack or queue semantics... I think it's the same thing here with the verifications.

@krancour krancour self-requested a review March 18, 2024 23:49
Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test drove and it works very smoothly!

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco added this pull request to the merge queue Mar 19, 2024
Merged via the queue into akuity:main with commit a95eaa5 Mar 19, 2024
16 checks passed
@hiddeco hiddeco deleted the add-verificationinfo-stack branch March 19, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintain verification history for a Stage
2 participants