Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display warehouses even if no stages are subscribed to it #1689

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

rbreeze
Copy link
Contributor

@rbreeze rbreeze commented Mar 27, 2024

No description provided.

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from a team as a code owner March 27, 2024 04:20
Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 675dd05
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66039e97440e8a000878a42f
😎 Deploy Preview https://deploy-preview-1689.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rbreeze rbreeze requested review from krancour and rpelczar March 27, 2024 04:21
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.93%. Comparing base (11a956e) to head (675dd05).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1689   +/-   ##
=======================================
  Coverage   43.93%   43.93%           
=======================================
  Files         203      203           
  Lines       13061    13061           
=======================================
  Hits         5739     5739           
  Misses       7075     7075           
  Partials      247      247           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour
Copy link
Member

I rebased this on main before test-driving it. It works perfectly, but I do notice that when I create a new Warehouse from the UI, it doesn't show up right away. If I refresh, it does show up -- meaning this PR does what it was meant to do.

I'll open a separate issue for getting the view to refresh after Warehouse creation.

@rbreeze rbreeze added this pull request to the merge queue Mar 27, 2024
@krancour
Copy link
Member

#1697

Merged via the queue into main with commit d59d53b Mar 27, 2024
19 checks passed
@rbreeze rbreeze deleted the wh-without-stages branch March 27, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants