fix(webhooks): label sync logic in webhooks #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
krancour
changed the title
✅ Deploy Preview for docs-kargo-akuity-io canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1703 +/- ##
==========================================
+ Coverage 44.17% 44.20% +0.03%
==========================================
Files 206 206
Lines 13139 13143 +4
==========================================
+ Hits 5804 5810 +6
+ Misses 7084 7083 -1
+ Partials 251 250 -1 ☔ View full report in Codecov by Sentry. |
hiddeco
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1699/#1701, this PR updates logic in webhooks to sync only one-way between important labels and their corresponding "convenience fields." This removes the surprising behavior that clearing such a field has no effect.