feat(api): add StartTime field to VerificationInfo
#1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-akuity-io canceled.
|
hiddeco
force-pushed
the
add-ts-to-verificationinfo
branch
from
3c198a0 to
3696164
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1705 +/- ##
==========================================
+ Coverage 44.30% 44.37% +0.07%
==========================================
Files 206 206
Lines 13091 13108 +17
==========================================
+ Hits 5800 5817 +17
Misses 7041 7041
Partials 250 250 ☔ View full report in Codecov by Sentry. |
krancour
reviewed
Mar 28, 2024
hiddeco
changed the title
Timestamp field to VerificationInfoStartTime field to VerificationInfo
krancour
approved these changes
Mar 28, 2024
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
add-ts-to-verificationinfo
branch
from
9043909 to
2c954be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up during a chat with @rpelczar, and would allow displaying a timestamp column in #1694. Giving the user a clearer idea about when a verification was (re)run.