Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): restore ability to read manifests from stdin #1715

Merged
merged 6 commits into from
Mar 29, 2024

Conversation

krancour
Copy link
Member

Fixes #1713 and reverts/replaces what was done in #1539

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour added this to the v0.5.0 milestone Mar 29, 2024
@krancour krancour self-assigned this Mar 29, 2024
@krancour krancour requested a review from a team as a code owner March 29, 2024 21:23
Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for docs-kargo-akuity-io canceled.

Name Link
🔨 Latest commit 6efee8d
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/6607346e9cdf1600071daf6a

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 44.18%. Comparing base (f696589) to head (6efee8d).

Files Patch % Lines
internal/cli/option/kubernetes.go 0.00% 25 Missing ⚠️
internal/cli/option/flag.go 0.00% 5 Missing ⚠️
internal/cli/cmd/apply/apply.go 0.00% 3 Missing ⚠️
internal/cli/cmd/create/create.go 0.00% 2 Missing ⚠️
internal/cli/cmd/delete/delete.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1715      +/-   ##
==========================================
- Coverage   44.37%   44.18%   -0.20%     
==========================================
  Files         206      207       +1     
  Lines       13108    13090      -18     
==========================================
- Hits         5817     5784      -33     
- Misses       7041     7065      +24     
+ Partials      250      241       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I count not depending on kubectl still as a major improvement, even if this is a second attempt 💯

@krancour krancour enabled auto-merge March 29, 2024 21:43
@krancour krancour added this pull request to the merge queue Mar 29, 2024
Merged via the queue into akuity:main with commit 361a02e Mar 29, 2024
14 of 16 checks passed
@krancour krancour deleted the krancour/cli-stuff branch March 29, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can no longer pipe inline manifest into kargo apply command
2 participants